Skip to content
This repository was archived by the owner on Mar 4, 2020. It is now read-only.

Virtualized table prototype#2339

Merged
pompomon merged 19 commits intomasterfrom
pompomon/virtualized-table
Feb 21, 2020
Merged

Virtualized table prototype#2339
pompomon merged 19 commits intomasterfrom
pompomon/virtualized-table

Conversation

@pompomon
Copy link
Contributor

Adding prototype for react-virtualized using Table component

@DustyTheBot
Copy link
Collaborator

DustyTheBot commented Feb 11, 2020

Warnings
⚠️ 8 perf regressions detected

Perf comparison

Status Scenario Fluent TPI Fabric TPI Ratio Iterations Ticks
🔧 Avatar.Fluent 0.52 0.41 1.27:1 2000 1030
🦄 Button.Fluent 0.12 0.19 0.63:1 1000 123
🔧 Checkbox.Fluent 0.79 0.28 2.82:1 1000 787
🔧 Dialog.Fluent 0.33 0.18 1.83:1 5000 1635
🔧 Dropdown.Fluent 3.43 0.37 9.27:1 1000 3429
🔧 Icon.Fluent 0.12 0.04 3:1 5000 603
🦄 Image.Fluent 0.04 0.08 0.5:1 5000 220
🔧 Slider.Fluent 1.41 0.31 4.55:1 1000 1407
🔧 Text.Fluent 0.05 0.02 2.5:1 5000 266
🦄 Tooltip.Fluent 0.09 18.32 0:1 5000 457

🔧 Needs work     🎯 On target     🦄 Amazing

Potential regressions comparing to master

Scenario Current PR Ticks Baseline Ticks Ratio
LoaderMinimalPerf.default 2209 748 2.95:1
AccordionMinimalPerf.default 215 170 1.26:1
DropdownMinimalPerf.default 3583 3200 1.12:1
HeaderMinimalPerf.default 430 390 1.1:1
ReactionMinimalPerf.default 2495 2342 1.07:1
EmbedMinimalPerf.default 6118 5882 1.04:1
AttachmentMinimalPerf.default 963 937 1.03:1
AttachmentSlotsPerf.default 3575 3814 0.94:1
Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
HeaderSlotsPerf.default 1597 1217 1.31:1
ListMinimalPerf.default 468 368 1.27:1
ListNestedPerf.default 868 682 1.27:1
SplitButtonMinimalPerf.default 13446 10902 1.23:1
AvatarMinimalPerf.default 607 501 1.21:1
PopupMinimalPerf.default 376 312 1.21:1
FormMinimalPerf.default 808 692 1.17:1
GridMinimalPerf.default 861 743 1.16:1
VideoMinimalPerf.default 743 643 1.16:1
Avatar.Fluent 1030 890 1.16:1
DividerMinimalPerf.default 955 832 1.15:1
InputMinimalPerf.default 986 883 1.12:1
CarouselMinimalPerf.default 1940 1741 1.11:1
ItemLayoutMinimalPerf.default 1645 1476 1.11:1
RefMinimalPerf.default 170 153 1.11:1
ButtonMinimalPerf.default 122 111 1.1:1
ChatWithPopoverPerf.default 539 494 1.09:1
CheckboxMinimalPerf.default 3548 3311 1.07:1
DropdownManyItemsPerf.default 422 393 1.07:1
LayoutMinimalPerf.default 619 580 1.07:1
TableMinimalPerf.default 572 536 1.07:1
TextAreaMinimalPerf.default 2929 2731 1.07:1
Dialog.Fluent 1635 1522 1.07:1
AnimationMinimalPerf.default 463 438 1.06:1
ButtonSlotsPerf.default 577 544 1.06:1
ListWith60ListItems.default 148 140 1.06:1
MenuMinimalPerf.default 1854 1750 1.06:1
MenuButtonMinimalPerf.default 1507 1421 1.06:1
BoxMinimalPerf.default 230 220 1.05:1
ChatDuplicateMessagesPerf.default 338 323 1.05:1
ImageMinimalPerf.default 231 220 1.05:1
SliderMinimalPerf.default 1612 1536 1.05:1
TreeMinimalPerf.default 873 833 1.05:1
Icon.Fluent 603 574 1.05:1
ListCommonPerf.default 883 845 1.04:1
StatusMinimalPerf.default 247 238 1.04:1
CustomToolbarPrototype.default 3495 3370 1.04:1
Checkbox.Fluent 787 756 1.04:1
Text.Fluent 266 256 1.04:1
FlexMinimalPerf.default 342 333 1.03:1
PortalMinimalPerf.default 240 233 1.03:1
Dropdown.Fluent 3429 3321 1.03:1
Slider.Fluent 1407 1372 1.03:1
DialogMinimalPerf.default 1606 1596 1.01:1
IconMinimalPerf.default 294 291 1.01:1
SegmentMinimalPerf.default 1263 1249 1.01:1
TooltipMinimalPerf.default 626 622 1.01:1
Button.Fluent 123 123 1:1
HierarchicalTreeMinimalPerf.default 776 786 0.99:1
LabelMinimalPerf.default 776 794 0.98:1
ToolbarMinimalPerf.default 811 824 0.98:1
Tooltip.Fluent 457 467 0.98:1
AlertMinimalPerf.default 539 555 0.97:1
ChatMinimalPerf.default 389 402 0.97:1
ProviderMergeThemesPerf.default 1074 1119 0.96:1
RadioGroupMinimalPerf.default 411 427 0.96:1
TextMinimalPerf.default 262 274 0.96:1
TreeWith60ListItems.default 217 232 0.94:1
ProviderMinimalPerf.default 583 639 0.91:1
Image.Fluent 220 255 0.86:1

Generated by 🚫 dangerJS

Co-Authored-By: Oleksandr Fediashov <olfedias@microsoft.com>
@pompomon pompomon merged commit f73ff62 into master Feb 21, 2020
@pompomon pompomon deleted the pompomon/virtualized-table branch February 21, 2020 14:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants